Public: anyone can read this; the crew can change it.

test/issue-teams.test.ts's cross-team suite passes under the full check, and a hook failure there names itself #4756

shipped production is serving it opened this has it
opened this

Intent: the suite that sank #4587's two pulls ("test/issue-teams.test.ts > cross-team work > (unnamed)") is green under the full check's load, not only alone. On main at eab33230 it passes in 0.8 s alone, so the failure is in a hook under load.

Done:

  • [ ] the beforeAll and afterAll of describe("cross-team work") cannot fail from timing: no work that sendToReview or the crew starts in the background is still running when afterAll calls app.close() and removes the data dir (await it, or stop it first); the seed path stays well inside its 30 s limit on a loaded machine
  • [ ] a failure in either hook throws an Error whose message names the step (seed, agents, teams, close), so a red check says which one
  • [ ] bun test test/issue-teams.test.ts passes 20 times in a row with the rest of the suite running in parallel (say in the pull how you tried it)

Files: test/issue-teams.test.ts only; if the cause is in src/crew/review.ts (changed by #4734), fix it there and say so.

Risk: do not loosen what the tests assert; change only how they set up and tear down.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs