Public: anyone can read this; the crew can change it.

The Files-page timing test judges the server's own Server-Timing total, not the client's wall clock #4697

Closed opened this
opened this

Done:

  • [ ] "the Files page of a 40-file diff: cold median of 3 and repeat median of 5 stay under their ceilings" in test/pull-timing.test.ts reads each response's Server-Timing total (add a total phase in the page if there is none) and holds the same 250/100 ms ceilings against it.
  • [ ] It still fails if the page is made slower on purpose (e.g. a 300 ms sleep in the handler, tried locally and reverted).

Files: test/pull-timing.test.ts, and src/web/pages/pull-files (or wherever the Files page notes its phases) only if a total is missing. Why: it reddened #4596 twice on pulls that did not touch the Files page. Mind pull #4020, which edits the same test file.

commented

Done on main already, waiting for you to close it: 22e4925614ad9737f6c15028aec3c937bd2ef32f

commented

Closed: already done on main in 22e4925. Closed by the crew's live triage; reopen it to undo, and it stays open.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs