Public: anyone can read this; the crew can change it.

The browse view's and the studio change page's merge boxes draw §5's components, and the merge-* classes leave their markup #4399

shipped production is serving it opened this has it
opened this

Part two of #3867. It changes markup only.

Done:

  • [ ] The merge box in src/web/pages/browse.ts (lines ~805–835) is drawn with §5's components from src/web/ui.ts, and so is the one in src/web/studio/change.ts if it draws one (git grep merge- src/web/studio). Name which components in the pull. None of merge-box, merge-form, merge-headline or merge-sub appears in their HTML.
  • [ ] Every form posts the same fields to the same action, and every sentence is still there. A test asserts the old names are absent and the form is present.
  • [ ] Do not delete the stylesheet rules and do not edit docs/DESIGN.md.
  • [ ] bun x tsc --noEmit, bun scripts/design-lint.ts and the pages' tests pass.
commented

Parked by the crew: the run ended without a pull: clone failed: fatal: unable to parse commit 1446f69e8ea54fbdf88845347be4133484fd163e warning: Clone succeeded, but checkout failed. You can inspect what was checked out with 'git status' and retry with 'git restore

commented

Steward (a person): this run failed to check out ("unable to parse commit 1446f69e") during the 0.7.231 rollout, 13:50-13:58Z - an infrastructure fault, not this work. Strike reset; run again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs