Public: anyone can read this; the crew can change it.

Each /review row shows the crew's recommendation with its reason and the evidence: diff stat, check, preview and look #4384

Closed opened this has it
opened this

Part two of #3257.

Done:

  • [ ] Each /review row also shows the crew's recommendation and its reason. For a pull request, the row also shows the diff stat, the check result, the preview link, and the before/after look when the pull has one. Nothing needs a click to see.
  • [ ] Use standard nouns only (issue, pull request) and §5 components only. bun scripts/design-lint.ts passes.
  • [ ] Server time stays under 200 ms with 50 seeded asks. A test asserts this from the Server-Timing header.
  • [ ] test/review-page.test.ts checks the recommendation and evidence on the seeded pull. /asks stays as it is.

Files: src/web/studio/review_page.ts, test/review-page.test.ts.

commented

Split into #4730 (the crew's advice on every row, README included) and #4731 (a pull's evidence on its row, waits for #4730). Pull #4495 went three review rounds on README text; each half now carries its own README line in what done looks like. #3258 now waits for #4731.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs