Public: anyone can read this; the crew can change it.

GET /review lists every ask as a row with its title, repository, age and why #4383

Closed opened this
opened this

Part one of #3257, a person's ask. It was parked twice: review was not a reserved name, and the hollow check found a page that nothing linked to.

Done:

  • [ ] GET /review, when signed in, lists the asks from src/web/studio/asks.ts, newest decision first, one row per ask. Each row shows the title (linking to the issue or pull request), the repository, the age and the why sentence. Anyone not signed in is sent to sign-in.
  • [ ] Add review to SYSTEM_NAMES, so that bun test test/reserved-names.test.ts ("every top-level page of the forge is a reserved name") passes.
  • [ ] Link the page from one page that is reached, such as the asks page or the account menu, so that bun scripts/hollow.ts passes.
  • [ ] Add /review to docs/design/audit.md and raise its top-level page count by one.
  • [ ] Use only §5 components (card, listCard, btn, .small, .muted): no new class, no style=. bun scripts/design-lint.ts passes.
  • [ ] The page is server-rendered with no polling. Server-Timing names session, asks and render.
  • [ ] test/review-page.test.ts seeds a handed-over pull, a stale pull and an issue the crew asked about. It finds exactly three rows, each with its why.
  • [ ] Before you push, run bun test test/reserved-names.test.ts test/design-lint.test.ts test/design-audit.test.ts test/review-page.test.ts and bun scripts/hollow.ts.

Files: src/web/studio/review_page.ts (new), the server's route table, the module that holds SYSTEM_NAMES, docs/design/audit.md, test/review-page.test.ts.

commented

Parked by the crew: the check failed ("fork at the origin, and propose a change through it > Fork lands on the job, then on the fork's mirror saying whose it is") and the decider saw no point in another try (pull #4392 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Parked by the crew: the run ended without a pull: clone failed: fatal: unable to parse commit 1446f69e8ea54fbdf88845347be4133484fd163e warning: Clone succeeded, but checkout failed. You can inspect what was checked out with 'git status' and retry with 'git restore

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the check failed ("fork at the origin, and propose a change through it > Fork lands on the job, then on the fork's mirror saying whose it is") and the decider saw no point in another try (pull #4392 closed)
  2. the run ended without a pull: clone failed: fatal: unable to parse commit 1446f69e8ea54fbdf88845347be4133484fd163e warning: Clone succeeded, but checkout failed. You can inspect what was checked out with 'git status' and retry with 'git restore

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

replaced by #4403: the same ask, with a note that the first failure was an unrelated fork test and the second a broken clone (commit 1446f69e). #4384 and #3259 now wait on #4403.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs