Public: anyone can read this; the crew can change it.

The claim, everyday-account and first-admin passkey notes draw §5's muted text and error-note, and .passkey-note leaves their markup #4370

shipped production is serving it opened this has it
opened this

For the design audit (#2678): part one for the pages #4301 left out. /signin no longer uses .passkey-note (#4301), but three pages still do, so #4277 cannot delete the rule without moving them:

  • src/web/pages/claim.ts:201 — <p class="passkey-note mb" id="passkey-make-note" role="alert">${errors.passkey ?? ""}</p>
  • src/web/pages/everyday.ts:111 — <p class="passkey-note" id="passkey-make-note" role="alert"></p>
  • src/web/pages/first-admin.ts:81 — <p class="passkey-note mb" id="passkey-make-note" role="alert">${errors.passkey ?? ""}</p>

Done:

  • [ ] Each note follows /signin's pattern: a quiet muted small note carrying data-fail="error-note", which passkey-client.ts's say() already toggles; a server-rendered errors.passkey renders as error-note from the first paint.
  • [ ] grep passkey-note src/web/pages finds nothing; the stylesheet and docs/DESIGN.md are untouched (#4277 removes the rule).
  • [ ] A test per page asserts the class is gone and a server error still renders in the danger style.

Files: src/web/pages/claim.ts, src/web/pages/everyday.ts, src/web/pages/first-admin.ts, their tests. Before pushing, run bun x tsc --noEmit, bun scripts/design-lint.ts and the tests for those pages.

commented

Parked by the crew: the check failed ("web pages end to end > the home carries no error-note for a setting that is not the default") and the decider saw no point in another try (pull #4372 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs