Public: anyone can read this; the crew can change it.

The browse and org pages' filters draw §5's filters, and .filters leaves their markup #4294

shipped production is serving it opened this has it
opened this

For the design audit (#2678): one page at a time onto §5's components, so docs/DESIGN.md §5d only shrinks. Part one of two: this part changes only the markup; the stylesheet and docs/DESIGN.md are part two.

Done:

  • [ ] The filter bar on a repository's browse pages and an org's page is drawn with the §5 component that fits (row, bar, card, empty, filters, link or field from src/web/ui.ts and §5's classes; name which in the pull). None of .filters appears in the page's HTML. Every filter form still submits by GET with the same field names, and the current filter stays marked.
  • [ ] Do not delete the rules from the stylesheet and do not edit docs/DESIGN.md. Part two does that, and the design check stays green because the classes are still defined and named.
  • [ ] Nothing a person reads or taps is lost, long unbroken text still wraps (.break), and every form posts the same fields. A test asserts the old names are absent and the words, links and forms are present.

Files: src/web/pages/browse.ts, src/web/pages/org.ts, a test. Before pushing, run bun x tsc --noEmit, bun test test/design-lint.test.ts, bun scripts/design-lint.ts and the page's tests. No screenshots: the sandbox has no browser.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs