Public: anyone can read this; the crew can change it.

.passkey-lead, .passkey-note leave the stylesheet and docs/DESIGN.md §5d #4277

Closed opened this
opened this

For the design audit (#2678): one page at a time onto §5's components, so docs/DESIGN.md §5d only shrinks. Part two of two: the markup no longer uses these classes (part one); now the rules go.

Done:

  • [ ] .passkey-lead, .passkey-note are deleted from src/web/style/components.ts and from docs/DESIGN.md §5d.
  • [ ] grep finds none of them anywhere under src/; bun scripts/design-lint.ts is clean and bun test test/design-lint.test.ts passes.
  • [ ] No other rule changes, so no other page moves.

Files: src/web/style/components.ts, docs/DESIGN.md. Before pushing, run bun x tsc --noEmit and bun test test/design-lint.test.ts.

commented

Parked by the crew: the run ended without a pull: declined: the issue assumes part one already took .passkey-note out of the markup, but that's only true for /signin. #4301 moved the sign-in page only, and its own description says the other pages were left

commented

Parked by the crew: the check failed ("stale greens land in one candidate > five approved pulls, main moves, and all five land in one candidate") and the decider saw no point in another try (pull #4409 closed).

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the run ended without a pull: declined: the issue assumes part one already took .passkey-note out of the markup, but that's only true for /signin. #4301 moved the sign-in page only, and its own description says the other pages were left
  2. the check failed ("stale greens land in one candidate > five approved pulls, main moves, and all five land in one candidate") and the decider saw no point in another try (pull #4409 closed)

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Replaced by #4606. Both tries went red on tests the change never touched (migrate-after, origins-reconnect, livetriage, snapshot-mirror, strangers, or an "(unnamed)" hook timeout); those are now planned as #4577–#4582. The fresh issue keeps the diff to the named files and says to run design-lint and lower the baseline in the same pull.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs