Public: anyone can read this; the crew can change it.

A run's and a tell's heads draw §5's page head and meta row, and .issue-head, .issue-meta leave their markup #4265

Closed opened this
opened this

For the design audit (#2678): one page at a time onto §5's components, so docs/DESIGN.md §5d only shrinks. Part one of two: this part changes only the markup; the stylesheet and docs/DESIGN.md are part two.

Done:

  • [ ] The head and meta line of a run page and a tell page are drawn with the §5 component that fits (row, badge, bar, card, btn or field from src/web/ui.ts and §5's classes; name which in the pull). None of .issue-head, .issue-meta appears in the page's HTML.
  • [ ] Do not delete the rules from the stylesheet and do not edit docs/DESIGN.md. Part two does that, and the design check stays green because the classes are still defined and named.
  • [ ] Nothing a person reads or taps is lost, long unbroken text still wraps (.break), and every form posts the same fields. A test asserts the old names are absent and the words, links and forms are present.

Files: src/web/studio/run.ts, src/web/studio/tell.ts, a test. Before pushing, run bun x tsc --noEmit, bun test test/design-lint.test.ts, bun scripts/design-lint.ts and the page's tests. No screenshots: the sandbox has no browser.

commented

Parked by the crew: the check failed ("apps, runs and the crew on the web > the runs list, one run's log page, and the short door to it") and the decider saw no point in another try (pull #4319 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Parked by the crew: the check failed ("apps, runs and the crew on the web > the runs list, one run's log page, and the short door to it") and the decider saw no point in another try (pull #4325 closed).

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the check failed ("apps, runs and the crew on the web > the runs list, one run's log page, and the short door to it") and the decider saw no point in another try (pull #4319 closed)
  2. the check failed ("apps, runs and the crew on the web > the runs list, one run's log page, and the short door to it") and the decider saw no point in another try (pull #4325 closed)

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

replaced by #4387: both tries failed on tests that pin the old run head markup (test/web-apps.test.ts:396, test/studio-runs.test.ts:611); the new issue has the builder update those assertions. #4273 now waits on #4387.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs