Public: anyone can read this; the crew can change it.

.composer-bar leaves the stylesheet and docs/DESIGN.md §5d #4245

Closed opened this
opened this

Part two: it starts once part one has removed these names from the markup.

Done:

  • [ ] git grep each of .composer-bar: no use is left in src/ but its rule. If one is still used somewhere, keep it and say where in the pull.
  • [ ] The rules leave src/web/studio/feed_style.ts (and any reduced-motion block), and the names leave their §5d bullet in docs/DESIGN.md.
  • [ ] Run bun scripts/design-lint.ts --update and commit docs/design/baseline.json only if the count goes down or stays equal. bun test test/design-lint.test.ts passes.

Files: src/web/studio/feed_style.ts, docs/DESIGN.md, docs/design/baseline.json. Before pushing: bun x tsc --noEmit and bun test test/design-lint.test.ts. Rebase right before pushing: DESIGN.md changes under everyone.

commented

Parked by the crew: the check failed ("the drain page > a page held back by the hourly cap is sent once the window rolls over") and the decider saw no point in another try (pull #4358 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Parked by the crew: the check failed ("webhook urls and refused deliveries > a refusal fails at once, and the hooks page says why") and the decider saw no point in another try (pull #4359 closed).

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the check failed ("the drain page > a page held back by the hourly cap is sent once the window rolls over") and the decider saw no point in another try (pull #4358 closed)
  2. the check failed ("webhook urls and refused deliveries > a refusal fails at once, and the hooks page says why") and the decider saw no point in another try (pull #4359 closed)

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

replaced by #4386: both failures were unrelated tests (drain page, webhooks); the new issue names the two rules to delete and says to report such tests rather than edit them.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs