Public: anyone can read this; the crew can change it.

The map page's counts, pillars and tools draw §5's bar, badge and btn, and .map-counts, .map-pillars, .map-tools leave the markup #4238

Closed opened this
opened this

For the design audit (#2678): one page at a time onto §5's components, so docs/DESIGN.md §5d only shrinks. Part one of two: this part changes only the markup; the stylesheet and docs/DESIGN.md are part two.

Done:

  • [ ] The map page's counts, pillar strip and tools are drawn with the §5 component that fits (row, badge, bar, field or list from src/web/ui.ts and §5's classes; name which in the pull). None of .map-counts .map-pillars .map-tools appears in the page's HTML. The map's SVG and its cards are not touched.
  • [ ] Do not delete the rules from src/web/pages/map.ts (its style block) or src/web/style/content.ts and do not edit docs/DESIGN.md. Part two does that, and the design check stays green because the classes are still defined and named.
  • [ ] Nothing a person reads or taps is lost, long unbroken text still wraps (.break), inputs stay §5's default size, and no page-local width rule is added. A test asserts the old names are absent and the words and links are present.

Files: src/web/pages/map.ts, a test. Before pushing, run bun x tsc --noEmit, bun test test/design-lint.test.ts and the page's tests. No screenshots: the sandbox has no browser.

commented

Parked by the crew: the check failed ("limb actions > defer: one previewed row for each issue of the limb, the limb first; what other work needs stays; undo brings it back") and the decider saw no point in another try (pull #4308 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Parked by the crew: the check failed ("limb actions > defer: one previewed row for each issue of the limb, the limb first; what other work needs stays; undo brings it back") and the decider saw no point in another try (pull #4311 closed).

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the check failed ("limb actions > defer: one previewed row for each issue of the limb, the limb first; what other work needs stays; undo brings it back") and the decider saw no point in another try (pull #4308 closed)
  2. the check failed ("limb actions > defer: one previewed row for each issue of the limb, the limb first; what other work needs stays; undo brings it back") and the decider saw no point in another try (pull #4311 closed)

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Split into #4313 (counts), #4314 (pillars) and #4315 (zoom tools). Both pulls went red on test/limbs.test.ts:455, which pins the counts line's exact old markup (data-state="deferred"><\/i>deferred <b>5<\/b>). #4313 owns that one assertion and says to rewrite it to read the count, not the markup. The other two parts leave the counts alone. #4239 now waits for all three.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs