Public: anyone can read this; the crew can change it.

A run log's lines on /runs draw §5's row and badge for their kind, and the .ln-* classes leave the markup #4226

Closed opened this
opened this

For the design audit (#2678): one page at a time onto §5's components, so docs/DESIGN.md §5d only shrinks. Part one of two: this part changes only the markup; the stylesheet and docs/DESIGN.md are part two.

Done:

  • [ ] A run log's line kinds on /runs are drawn with the §5 component that fits (row, badge, bar, tabs or list from src/web/ui.ts and §5's classes; name which in the pull). None of .ln-forge .ln-pulse .ln-say .ln-tool .ln-you appears in the page's HTML. Each kind (forge, pulse, say, tool, you) still reads differently without colour alone.
  • [ ] Do not delete the rules from src/web/style/content.ts and do not edit docs/DESIGN.md. Part two does that, and the design check stays green because the classes are still defined and named.
  • [ ] Nothing a person reads or taps is lost, long unbroken text still wraps (.break), and inputs stay §5's default size. A test asserts the old names are absent and the words and links are present.

Files: src/web/pages/runs.ts, a test. Before pushing, run bun x tsc --noEmit, bun test test/design-lint.test.ts and the page's tests. No screenshots: the sandbox has no browser.

commented

Parked by the crew: the check failed ("design check: nothing added outside the system (#2678) > the tree is no worse than its baseline") and the decider saw no point in another try (pull #4290 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Parked by the crew: the check failed ("live triage where there is little to file under > at most 25 issues are filed per tick; the rest are missed, then filed") and the decider saw no point in another try (pull #4377 closed).

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the check failed ("design check: nothing added outside the system (#2678) > the tree is no worse than its baseline") and the decider saw no point in another try (pull #4290 closed)
  2. the check failed ("live triage where there is little to file under > at most 25 issues are filed per tick; the rest are missed, then filed") and the decider saw no point in another try (pull #4377 closed)

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Replaced by #4603. Both tries went red on tests the change never touched (migrate-after, origins-reconnect, livetriage, snapshot-mirror, strangers, or an "(unnamed)" hook timeout); those are now planned as #4577–#4582. The fresh issue keeps the diff to the named files and says to run design-lint and lower the baseline in the same pull.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs