Public: anyone can read this; the crew can change it.

The home KPI row's sparklines draw §5's components, and .kpi-spark leaves the markup #4191

Closed opened this
opened this

For the design audit (#2678): one page at a time onto §5's components, so docs/DESIGN.md §5d only shrinks. Part one of two: this part changes only the markup; the stylesheet and docs/DESIGN.md are part two.

Done:

  • [ ] The home KPI row's sparklines are drawn with the §5 component that fits (row, badge, bar, field or table from src/web/ui.ts and §5's classes; name which in the pull). None of .kpi-spark appears in the page's HTML. The sparkline keeps its size, so the row does not shift.
  • [ ] Do not delete the rules from src/web/studio/feed_style.ts and do not edit docs/DESIGN.md. Part two does that, and the design check stays green because the classes are still defined and named.
  • [ ] Nothing a person reads or taps is lost, long unbroken text still wraps (.break), and every form posts the same fields. A test asserts the old names are absent and the words, links and forms are present.

Files: src/web/studio/kpi_row.ts, a test. Before pushing, run bun x tsc --noEmit, bun test test/design-lint.test.ts and the page's tests. No screenshots: the sandbox has no browser.

commented

Done on main already, waiting for you to close it: 89d8dcc6f4aa6237b8f3ef57faaa9a62397213af

commented

Closed: already done on main in 89d8dcc. Closed by the crew's live triage; reopen it to undo, and it stays open.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs