Public: anyone can read this; the crew can change it.

.origin-row, .origin-name, .origin-mark, .mirror-form leave the stylesheet and docs/DESIGN.md §5d #4143

Closed opened this
opened this

Part two of #3943. It starts once part one has removed these names from the markup.

Done:

  • [ ] git grep each of .origin-row .origin-name .origin-mark .mirror-form: no use is left in src/ but its rule. If one is still used somewhere, keep it and say where in the pull.
  • [ ] The rules leave src/web/style/content.ts (and its reduced-motion block), and the names leave their §5d bullet in docs/DESIGN.md.
  • [ ] Run bun scripts/design-lint.ts --update and commit docs/design/baseline.json only if the count goes down or stays equal. bun test test/design-lint.test.ts passes.

Files: src/web/style/content.ts, docs/DESIGN.md, docs/design/baseline.json. Before pushing: bun x tsc --noEmit and bun test test/design-lint.test.ts. Rebase right before pushing: DESIGN.md changes under everyone.

commented

Parked by the crew: the check failed ("the drain page > a drain started the way main.ts starts it, with the notifier stopped beside it, is still paged") and the decider saw no point in another try (pull #4452 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Parked by the crew: the check failed ("(unnamed)") and the decider saw no point in another try (pull #4473 closed).

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the check failed ("the drain page > a drain started the way main.ts starts it, with the notifier stopped beside it, is still paged") and the decider saw no point in another try (pull #4452 closed)
  2. the check failed ("(unnamed)") and the decider saw no point in another try (pull #4473 closed)

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Replaced by #4599. Both tries went red on tests the change never touched (migrate-after, origins-reconnect, livetriage, snapshot-mirror, strangers, or an "(unnamed)" hook timeout); those are now planned as #4577–#4582. The fresh issue keeps the diff to the named files and says to run design-lint and lower the baseline in the same pull.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs