Public: anyone can read this; the crew can change it.

No pull has a review gate: nothing ever queues the reviewer pass, and an autonomous repo lands any green pull, a person's included, unseen #414

shipped production is serving it opened this has it
opened this

From the audit in #385 (a person's pull gets the same gate as an agent's).

What is there. runner.ts and brief.ts know a review run reason, and dispatch.ts reacts to a crew reviewer's verdict. But no code calls queueAgentRun(..., "review"), so the reviewer pass never starts. landIfGreen (src/crew/autonomy.ts) comments that the decider looks "first" through the crew's reviewer, yet it records a rule-made ship and merges as soon as checks and the policy wall pass. It does not look at who authored the pull.

What is missing. One gate for every pull: when a crew has a reviewer, a head is queued for review when its checks go green, and landIfGreen waits for an approval on that head (a person's approval counts the same) whether the author is an agent or a person. With no reviewer on the crew the behaviour stays as it is, and the pull says so.

Done when. A green pull by a person and one by an agent both get a review run in an autonomous repo and neither lands before approval on its head; a new push resets it. Tests for both authors.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs