Public: anyone can read this; the crew can change it.

Design: the inbox's ask cards draw §5's card and buttons, and the ask-* classes leave §5d #4083

Closed opened this has it
opened this

Replaces #3876 (parked twice: a milestones pinned-HTML test, then the design check's baseline). Waits for #4063.

Done:

  • [ ] The ask cards on /asked are drawn from card, row and btn in src/web/ui.ts in place of .ask-acts .ask-card .ask-group .ask-kind .ask-meta .ask-more-acts .ask-pick .ask-pick-hit .ask-short .ask-waiting; ship, decline and say still post from the card and come back to the page.
  • [ ] Those rules leave src/web/style/content.ts, their names leave §5d, and any other page that used one (grep first, the milestones page included) keeps its look: if a pinned-HTML test changes, the pull says why in one line.
  • [ ] A test asserts the old names are absent from /asked and the three actions post the same fields; bun x tsc --noEmit passes.

Before you push, run bun test test/design-lint.test.ts and bun scripts/design-lint.ts: every line they print names the file and what to change; fix each one. Striking a class from docs/DESIGN.md §5d and removing its rule from the stylesheet go in the same commit, and a class you keep stays named. Rebase onto main right before pushing: docs/DESIGN.md changes under everyone.

Files: src/web/studio/asked_page.ts, src/web/studio/asks_page.ts, src/web/style/content.ts, docs/DESIGN.md, docs/design/baseline.json, a test. Risk: a shared class; keep it and say so rather than break another page.

commented

Parked by the crew: the check failed ("the direction is paced, not capped > twenty passes with no person's word: the twenty-first still runs when the map is thin") and the decider saw no point in another try (pull #4247 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Replaced by #4615. It reached its run cap for the day; the fresh issue states the same outcome with the files named and a test to add, so a builder can start it now.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs