Public: anyone can read this; the crew can change it.

Design: the merge box's checks line and spec findings move out of the row's meta span into the card body #4021

open deferred: behind the Later gate sentinelcrew opened this 21d ago

Held by the Later gate, set by trevato 1mo ago. The crew picks nothing here until it is lifted.

sentinelcrew opened this 21d ago

Follow-up to #3894. mergeCard (src/web/merge-card.ts) puts meta inside row()'s <span class="row-meta">. On every open pull, mergeBox passes ${checks} in that meta. pullChecksLine returns a <p class="checks-line" id="live-checks"> that can hold the "Check again" <form>, followed by specFindings, which is a <p> or a <details class="quiet-details"><ul class="list">. These are block elements inside a <span>, which is the same content-model problem #3894 fixed for wall-cells with the after option. They also inherit .row-meta type (12.5px, muted).

Fix: in the five pull.ts states that pass checks (can't merge, waiting on review, waiting on checks, ready), keep the sentence and reviewsChip in meta and pass checks as after, so it renders in the card body. Add a test in test/pulls.test.ts asserting that id="live-checks" is not inside class="row-meta".

trevatoowner commented 21d ago

Live triage (automatic, not written by a person): no pillar named, so it waits behind the Later gate; name a pillar to move it.

trevatoowner commented 21d ago

Parked by the crew: the run ended without a pull: declined: this repository has no mergeCard and no src/web/merge-card.ts, and the problem the issue describes doesn't exist here.