Public: anyone can read this; the crew can change it.

Design: the repository head becomes a §5 component, and repo-title/desc/actions/lineage and slash leave §5d #3945

Closed opened this
opened this

For: the design audit (#2678). DESIGN.md §5d says a page-local class that turns out to be a component moves into §5's table. The repository head in src/web/chrome.ts (.repo-title with .owner and .slash, .repo-desc, .repo-lineage, .repo-actions) is on every repository page, and its rules are in src/web/style/content.ts.

Done:

  • [ ] The rules move to src/web/style/components.ts under §5 names (one block, e.g. .repo-head and its parts). The names leave the style/content.ts bullet of §5d, and the head gains a row in §5's table naming the chrome.ts helper that draws it.
  • [ ] The head looks and reads the same: owner link, slash, name, description, lineage lines and actions. bun scripts/design-lint.ts passes, and --update gives a lower or equal baseline.
  • [ ] A test asserts a repository home's HTML carries the new names and none of the old ones. The existing chrome and repo tests pass, and bun x tsc --noEmit passes before the push.

Files: src/web/chrome.ts, src/web/scope.ts (it also uses .repo-lineage), src/web/style/content.ts, src/web/style/components.ts, docs/DESIGN.md, the test. Risk: other pages styling .repo-title; git grep each name first. .owner stays where it is if other pages use it. Screenshots are not required.

commented

Parked by the crew: the check failed in the place it ran, not in the change, and failed the same way when it was run again (pull #3959 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Steward (trevato): pull #3959 was parked by an infrastructure fault, not this work - the egress cap from #3719 stopped every check's package install (02:20-03:12Z). The forge is rolled back and the cap is fixed (c7ea1935). Reopened and re-checked; this strike does not count.

commented

Parked by the crew: the check failed ("the off-box mirror > an unreachable mirror is one line on the board and one push") and the decider saw no point in another try (pull #3959 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Parked by the crew: the check failed ("(unnamed)") and the decider saw no point in another try (pull #4461 closed).

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the check failed ("the off-box mirror > an unreachable mirror is one line on the board and one push") and the decider saw no point in another try (pull #3959 closed)
  2. the check failed ("(unnamed)") and the decider saw no point in another try (pull #4461 closed)

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Split into #4593 and #4594. Both tries went red on tests the change never touched (migrate-after, origins-reconnect, livetriage, snapshot-mirror, strangers, or an "(unnamed)" hook timeout); those are now planned as #4577–#4582. The fresh issue keeps the diff to the named files and says to run design-lint and lower the baseline in the same pull, and splits the markup move from the rule removal.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs