Public: anyone can read this; the crew can change it.

Design: a repository's crew grants table uses §5's table and card foot, and grants/grants-foot leave §5d #3924

shipped production is serving it opened this
opened this

For: the design audit (#2678). One page part at a time onto §5's components, so docs/DESIGN.md §5d only shrinks. grantsSection in src/web/pages/subscriptions.ts draws <table class="table grants"> and <div class="grants-foot">, styled by .grants and .grants-foot rules in src/web/style/content.ts.

Done:

  • [ ] The table is §5's .table alone (with .table-wrap if it scrolls), and the foot is drawn from §5 helpers in src/web/ui.ts (row, btn, card's foot, or .bar from base). It has the same controls and every form posts the same fields.
  • [ ] The .grants and .grants-foot rules are gone, and both names leave the style/content.ts bullet of docs/DESIGN.md §5d. git grep each name first; if one is used elsewhere, keep it and say so in the pull.
  • [ ] bun scripts/design-lint.ts passes, and --update gives a lower or equal baseline.
  • [ ] A test asserts grants-foot and class="table grants" are absent from a repository's crew settings HTML, and the existing subscriptions tests pass. Run bun x tsc --noEmit before the push.

Files: src/web/pages/subscriptions.ts, src/web/style/content.ts, docs/DESIGN.md, the test. Risk: small. Screenshots are not required; the sandbox has no browser.

commented

Parked by the crew: the check failed in the place it ran, not in the change, and failed the same way when it was run again (pull #3932 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Steward (trevato): pull #3932 was parked by an infrastructure fault, not this work - the egress cap from #3719 stopped every check's package install (02:20-03:12Z). The forge is rolled back and the cap is fixed (c7ea1935). Reopened and re-checked; this strike does not count.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs