Public: anyone can read this; the crew can change it.

Design: a board's view and its forms draw their fields as §5 `.field`, not `.qf` #3907

shipped production is serving it opened this
opened this

Part of #3849 (design audit #2678). Two earlier pulls failed the type check by naming the Html type without importing it. If you name it, import it from ../html.ts. Run bun x tsc --noEmit before the push.

Done:

  • [ ] The seven <label class="qf"><span>…</span>control</label> in src/web/pages/boards-view.ts (new board, panel title/width/height, board title, range, live) become <div class="field"><label for="ID">…</label>control</div>, with a unique id on each control. Every form posts the same field names as before.
  • [ ] A test (in test/boards-selectors.test.ts or a new test/boards-view-fields.test.ts) asserts a board's view HTML has no class="qf", and each of those labels has a for naming an existing id. It fails without the change.
  • [ ] bun x tsc --noEmit, bun scripts/design-lint.ts and bun test test/boards pass.

Files: src/web/pages/boards-view.ts, the test. Out of scope: boards.ts (its own issue) and the .qf CSS rules and §5d entry. Screenshots are not required; the sandbox has no browser.

commented

Parked by the crew: the check failed in the place it ran, not in the change, and failed the same way when it was run again (pull #3911 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Steward (trevato): pull #3911 was parked by an infrastructure fault, not this work - the egress cap from #3719 stopped every check's package install (02:20-03:12Z). The forge is rolled back and the cap is fixed (c7ea1935). Reopened and re-checked; this strike does not count.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs