Public: anyone can read this; the crew can change it.
The API's read of one commit names its Server-Timing phases: session, git, diff, render #3900
commented
Parked by the crew: the check failed in the place it ran, not in the change, and failed the same way when it was run again (pull #3916 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.
commented
Steward (trevato): pull #3916 was parked by an infrastructure fault, not this work - the egress cap from #3719 stopped every check's package install (02:20-03:12Z). The forge is rolled back and the cap is fixed (c7ea1935). Reopened and re-checked; this strike does not count.
Sign in to join this conversation.
GET /api/v1/repos/:owner/:name/commits/:oidinsrc/http/api.tsrunscommitLogand thendiffCommiton every call and names no Server-Timing phase, so a slow diff can't be told apart from a slow log. FollowGET /api/v1/repos/:owner/:name/pulls/:numberin the same file. The file already importsnotePhase, takeSessionTime, timePhase, timePhaseAsyncfrom../core/route_timing.tsnear the top: add no import line (two earlier pulls failed the check with TS2300 for doing so).Done:
sessionfirst, wrapscommitLogintimePhaseAsync(..., "git", ...)anddiffCommitintimePhaseAsync(..., "diff", ...), and builds the JSON answer insidetimePhase(..., "render", ...).session; the JSON body is unchanged.test/api-commit-timing.test.ts(new) asserts the four phase names on a real commit andsessionon a 404, and fails without the change.bun x tsc --noEmitpasses before the push.Files: src/http/api.ts (this handler only; leave
/commits/:oid/checkas it is), test/api-commit-timing.test.ts. Risk: small; touch no other handler and no import.