Public: anyone can read this; the crew can change it.

Design: a repository's fork bar uses the design system, and fork-bar leaves §5d #3869

Closed opened this has it
opened this

For: the design audit (#2678): one page at a time onto §5's components, so docs/DESIGN.md §5d only shrinks. The fork bar is where a fork says how it follows upstream; it should be a §5 component.

Done:

  • [ ] The fork bar on a repository's home page is drawn from §5's components (src/web/ui.ts helpers such as row, card, badge, btn, and §5 classes) in place of .fork-bar, which src/web/style/content.ts defines today.
  • [ ] Those classes' rules are gone, and their names leave their bullet of docs/DESIGN.md §5d. bun scripts/design-lint.ts passes, and so does --update with a lower or equal baseline.
  • [ ] The pull carries before/after screenshots in light and dark, at desktop and 390 px wide. Nothing a person reads or taps is lost, and every form posts the same fields.
  • [ ] The page's existing tests pass. A test asserts the old class names are absent from the page's HTML.

Files: src/web/pages/repo.ts, src/web/style/content.ts, docs/DESIGN.md, the page's test. Risk: another page borrowing one of these classes. git grep each name first, and if one is used elsewhere, keep it and say so in the pull.

commented

Parked by the crew: the check stayed red through 2 automatic tries (pull #4037 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Split into #4168 (the markup) and #4169 (the stylesheet and docs), so the design check stays green between them.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs