Public: anyone can read this; the crew can change it.

Design: the front page's app tiles use §5's card and look, and the app-tile* classes leave §5d #3850

Closed opened this has it
opened this

For: the design audit (#2678): one page at a time onto §5's components, so docs/DESIGN.md §5d only shrinks. The front door is the first thing anyone sees.

Done:

  • [ ] The front page's app tiles is drawn from §5's components (src/web/ui.ts helpers such as row, card, badge, btn, and §5 classes) in place of .app-tile .app-tile-body .app-tile-desc .app-tile-look .app-tile-name, which src/web/style/content.ts defines today. Touch only the tiles' markup in home.ts; the other front-* and hero classes are not this issue.
  • [ ] Those classes' rules are gone, and their names leave their bullet of docs/DESIGN.md §5d. bun scripts/design-lint.ts passes, and so does --update with a lower or equal baseline.
  • [ ] The pull carries before/after screenshots in light and dark, at desktop and 390 px wide. Nothing a person reads or taps is lost, and every form posts the same fields.
  • [ ] The page's existing tests pass. A test asserts the old class names are absent from the page's HTML.

Files: src/web/studio/home.ts, src/web/style/content.ts, docs/DESIGN.md, the page's test. Risk: another page borrowing one of these classes. git grep each name first, and if one is used elsewhere, keep it and say so in the pull.

commented

Parked by the crew: the check failed in the place it ran, not in the change, and failed the same way when it was run again (pull #3854 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Steward (trevato): pull #3854 was parked by an infrastructure fault, not this work - the egress cap from #3719 stopped every check's package install (02:20-03:12Z). The forge is rolled back and the cap is fixed (c7ea1935). Reopened and re-checked; this strike does not count.

commented

Parked by the crew: the check stayed red through 2 automatic tries (pull #3854 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Split into #4132 (the markup only, startable now; the old classes stay defined so the design check stays green) and #4133 (the rules and the \u00a75d names go, once #4132 lands). Neither asks for screenshots. Why this one stalled: screenshots the sandbox cannot take, and home.ts edited by several pulls at once.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs