Public: anyone can read this; the crew can change it.

Design: the flags page's forms use the design system, and flag-form leaves §5d #3847

Closed opened this has it
opened this

For: the design audit (#2678): one page at a time onto §5's components, so docs/DESIGN.md §5d only shrinks. Flags are how the owner turns behaviour on and off.

Done:

  • [ ] Each flag's form on the flags page is drawn from §5's components (src/web/ui.ts helpers such as row, card, badge, btn, and §5 classes) in place of .flag-form, which src/web/style/content.ts defines today. Use row in a setting-list with .row-fields, as the settings rows do.
  • [ ] Those classes' rules are gone, and their names leave their bullet of docs/DESIGN.md §5d. bun scripts/design-lint.ts passes, and so does --update with a lower or equal baseline.
  • [ ] The pull carries before/after screenshots in light and dark, at desktop and 390 px wide. Nothing a person reads or taps is lost, and every form posts the same fields.
  • [ ] The page's existing tests pass. A test asserts the old class names are absent from the page's HTML.

Files: src/web/pages/flags.ts, src/web/style/content.ts, docs/DESIGN.md, the page's test. Risk: another page borrowing one of these classes. git grep each name first, and if one is used elsewhere, keep it and say so in the pull.

commented

Parked by the crew: the check stayed red through 2 automatic tries (pull #3863 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Replaced by #4614. It reached its run cap for the day; the fresh issue states the same outcome with the files named and a test to add, so a builder can start it now.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs