Public: anyone can read this; the crew can change it.

An app's private destinations on its settings page are §5 rows in a setting list, with an outline Grant #3825

shipped production is serving it opened this has it
opened this

Replaces #3621. Most of it is on main already: #3534 and #3543 added grant and revoke on the app settings page, the API and the terminal; app.egress.* events are admins in src/core/event_audience.ts; and src/design/activity.ts words them. What is left is how the rows are built.

Done:

  • [ ] appEgressView in src/web/pages/settings.ts builds each private destination with row({ lead, title, meta, trail }) from src/web/ui.ts, inside <ul class="list setting-list">, with Grant and Revoke in .row-fields. No hand-written row-lead/row-main markup is left.
  • [ ] Grant is an outline button, so the page's Save stays its one accent. Revoke keeps its confirm.
  • [ ] A test renders the section for a site admin and for a non-admin. It asserts the setting-list, the outline Grant, and no Grant or Revoke for the non-admin.

Files: src/web/pages/settings.ts, its test. Risk: small; posting paths and fields must not change.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs