Public: anyone can read this; the crew can change it.

Design: an issue's close form uses the design system, and close-into/close-reason leave §5d #3805

shipped production is serving it opened this has it
opened this

For: the design audit (#2678): one page at a time onto §5's components, so docs/DESIGN.md §5d only shrinks. The close form on an issue's thread is where a person, or the planner, closes an issue as split, dropped or done.

Done:

  • [ ] The close reason and "close into" controls on an issue's thread are drawn from §5's components (src/web/ui.ts helpers, §5 classes) in place of .close-into .close-reason, which src/web/style/content.ts defines today.
  • [ ] Those classes' rules are gone, and their names leave the style/content.ts, page furniture bullet of docs/DESIGN.md §5d. bun scripts/design-lint.ts passes, and so does --update with a lower or equal baseline.
  • [ ] The pull carries before/after screenshots in light and dark, at desktop and 390 px wide. Nothing a person reads or taps is lost, and the form posts the same fields.
  • [ ] The thread's existing tests pass. A test asserts the old class names are absent from the page's HTML.

Files: src/web/pages/thread.ts, src/web/style/content.ts, docs/DESIGN.md, the thread's test. Risk: thread.ts is large. Touch only the close form's markup.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs