Public: anyone can read this; the crew can change it.

The API's run log read names its Server-Timing phases: session, log, render #3782

shipped production is serving it opened this has it
opened this

GET /api/v1/repos/:owner/:name/runs/:id/log in src/http/api.ts serves a run's log, as plain text or as a stream when it is followed. The plain answer names no Server-Timing phase.

Done:

  • [ ] The plain (non-follow) answer's Server-Timing names session, log (runLog) and render (joining the lines), using notePhase and timePhase from src/core/route_timing.ts.
  • [ ] A hidden or missing log still answers 404, with session named. The follow (event-stream) path is unchanged.
  • [ ] test/api-run-log-timing.test.ts asserts the phase names for a finished run, and fails without the change. The text body is unchanged.

Files: src/http/api.ts (this handler only), test/api-run-log-timing.test.ts (new). Risk: small; never add headers to the streaming answer after it starts.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs