Public: anyone can read this; the crew can change it.
The API's read of one pull names its Server-Timing phases: session, pull, head, diff, checks, render #3765
Sign in to join this conversation.
Public: anyone can read this; the crew can change it.
GET /api/v1/repos/:owner/:name/pulls/:numberinsrc/http/api.tsis what every reviewer and builder on the crew reads: it refreshes the head, computes the diff and the check summary. It names no Server-Timing phase, so a slow review read cannot be traced to its part.Done:
session,pull(loadPull),head(refreshPullHead),diff(pullDiff),checks(thecheckSummaryread and the baseresolveOid) andrender(building the JSON), usingnotePhase,timePhaseandtimePhaseAsyncfromsrc/core/route_timing.ts.sessionandpull.test/api-pull-timing.test.tsasserts the phase names for an open pull and fails without the change. The JSON body is unchanged: an existing API pull test still passes.Files: src/http/api.ts (this one handler only), test/api-pull-timing.test.ts (new). Risk: small; touch no other handler in
api.ts, so this does not collide with the issue-read issue.