Public: anyone can read this; the crew can change it.

A limb's re-plan preview names its Server-Timing phases: session, repo, plan, render #3740

shipped production is serving it opened this has it
opened this

GET /:owner/:name/milestones/:number/limb?action=replan goes through limbPreviewPage in src/web/pages/limb.ts. That handler notes session and repo, then hands off to replanPreviewPage in src/web/pages/limb_replan.ts, which records nothing else. The page's Server-Timing therefore has no plan or render phase, unlike every other limb action (#3510).

Done:

  • [ ] In replanPreviewPage, previewReplan runs inside timePhase(ctx.request, "plan", …), and the page build is noted as render, using src/core/route_timing.ts the way limbPreviewPage already does.
  • [ ] test/limb-timing.test.ts gains a case for ?action=replan that asserts session, repo, plan and render are named. The case fails without the change.
  • [ ] test/limb-replan.test.ts still passes, and the page's HTML is unchanged.

Files: src/web/pages/limb_replan.ts, test/limb-timing.test.ts. Risk: small; the not-found and signed-out paths stay as they are.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs