Public: anyone can read this; the crew can change it.

The new pull page names its Server-Timing phases: session, the compare, render #3634

shipped production is serving it opened this has it
opened this

For: speed you can see, page by page. The new pull page (newPullPage in src/web/pages/pulls.ts, GET /:owner/:name/pulls/new) reports one opaque number in Server-Timing.

Done:

  • [ ] The handler calls notePhase from src/core/route_timing.ts, the way src/web/pages/releases.ts and src/web/studio/explore.ts do. The phases are session, compare (the branch list and the base…head comparison), and render.
  • [ ] The page renders exactly as today.
  • [ ] A new test/new-pull-timing.test.ts GETs the page and finds every phase name in Server-Timing. It fails without the change.

Files: src/web/pages/pulls.ts, test/new-pull-timing.test.ts. Risk: none to behaviour. Measure only; do not add caching here.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs