Public: anyone can read this; the crew can change it.

One commit's page names its Server-Timing phases: session, git, render #3632

shipped production is serving it opened this has it
opened this

For: speed you can see, page by page. One commit's page (commitPage in src/web/pages/commits.ts, GET /:owner/:name/commit/:oid) reports one opaque number in Server-Timing.

Done:

  • [ ] The handler calls notePhase from src/core/route_timing.ts, the way src/web/pages/releases.ts and src/web/studio/explore.ts do. The phases are session, git (the commit and its diff read), highlight if the diff is highlighted, and render.
  • [ ] The page renders exactly as today.
  • [ ] A new test/commit-page-timing.test.ts GETs the page and finds every phase name in Server-Timing. It fails without the change.

Files: src/web/pages/commits.ts, test/commit-page-timing.test.ts. Risk: none to behaviour. Measure only; do not add caching here.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs