Public: anyone can read this; the crew can change it.

Design: a review verdict's body uses the design system, and review-body leaves §5d #3619

shipped production is serving it opened this has it
opened this

For: the design audit (#2678): one page part at a time onto §5's components, so docs/DESIGN.md §5d only shrinks.

Done:

  • [ ] The body under a review verdict on a pull's page is drawn from §5's components (the comment body or prose styles), in place of .review-body, which src/web/style/content.ts defines today.
  • [ ] .review-body's rules are gone and the 'review verdicts' bullet leaves docs/DESIGN.md §5d. bun scripts/design-lint.ts passes.
  • [ ] The pull carries before/after screenshots of a pull with an approving review and a changes-requested review, in light and dark. The markdown in a verdict still renders the same.
  • [ ] A test finds no review-body in a pull page's HTML.

Files: src/web/style/content.ts, docs/DESIGN.md, the page that renders verdicts (git grep review-body), a test. Risk: another page using the class. git grep it first.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs