For: #3495, re-planned after two pulls failed their check. #3517 changed src/ for a seam. This piece makes the file smaller by moving tests, which is mechanical, instead of rewriting them.
Done:
[ ] The describe("an issue found already done is the asker's to close, not a park") block and every test after it (line 1287 to the end on main) move to a new test/crew-parks-done.test.ts.
[ ] No file under src/ changes, so the type check cannot fail on this pull. Every test and assertion moves unchanged, and the shared helpers at the top of test/crew-parks.test.ts (lines 1–158 on main 8885c0b3) are copied into the new file, or moved into a test/helpers/ module that both files import. scripts/gate.ts finds test files by reading test/, so the new file joins the gate by itself.
[ ] bun test test/crew-parks.test.ts test/crew-parks-done.test.ts passes with the same 32 tests between them. Each file runs under 10 s, with the times named in the pull.
Files: test/crew-parks.test.ts, test/crew-parks-done.test.ts, and a test/helpers/ file if one is made.
Risk: a test that depended on state left by an earlier test in the old file. If one fails alone, give it its own setup, and name it in the pull.
For: #3495, re-planned after two pulls failed their check. #3517 changed
src/for a seam. This piece makes the file smaller by moving tests, which is mechanical, instead of rewriting them.Done:
describe("an issue found already done is the asker's to close, not a park")block and every test after it (line 1287 to the end on main) move to a newtest/crew-parks-done.test.ts.src/changes, so the type check cannot fail on this pull. Every test and assertion moves unchanged, and the shared helpers at the top oftest/crew-parks.test.ts(lines 1–158 on main 8885c0b3) are copied into the new file, or moved into atest/helpers/module that both files import.scripts/gate.tsfinds test files by readingtest/, so the new file joins the gate by itself.bun test test/crew-parks.test.ts test/crew-parks-done.test.tspasses with the same 32 tests between them. Each file runs under 10 s, with the times named in the pull.Files:
test/crew-parks.test.ts,test/crew-parks-done.test.ts, and atest/helpers/file if one is made. Risk: a test that depended on state left by an earlier test in the old file. If one fails alone, give it its own setup, and name it in the pull.