Split from #3347, whose two pulls failed on a wall-clock assertion inside a loaded check. This step makes the speed work safe; it changes no product code.
Done:
[ ] A seed helper in the test (or test/fixtures/) makes one repository with 20 milestones (umbrella issues with waiting children) over 1,000 issues, 900 closed, and a week of merged pulls, deterministically (fixed ids, fixed now).
[ ] test/milestones-golden.test.ts renders GET /:owner/:name/milestones on that seed and compares the HTML, with the nonce and the times normalised, against the text it pins; it fails when the page's output changes.
[ ] No wall-clock assertion anywhere in it.
Files: test/milestones-golden.test.ts and its seed. Touch nothing in src/.
Split from #3347, whose two pulls failed on a wall-clock assertion inside a loaded check. This step makes the speed work safe; it changes no product code.
Done:
test/fixtures/) makes one repository with 20 milestones (umbrella issues with waiting children) over 1,000 issues, 900 closed, and a week of merged pulls, deterministically (fixed ids, fixednow).test/milestones-golden.test.tsrendersGET /:owner/:name/milestoneson that seed and compares the HTML, with the nonce and the times normalised, against the text it pins; it fails when the page's output changes.Files:
test/milestones-golden.test.tsand its seed. Touch nothing insrc/.