The next one in the series that went /explore (#3234), /settings/crew (#3235) and an issue page (#3222). GET /:owner/:name/settings/app in src/web/pages/settings.ts reports one opaque time. It reads vitals, env names and domains before it renders.
Done looks like:
[ ] The handler calls notePhase from src/core/route_timing.ts for session (via takeSessionTime), vitals (the appVitals read), domains (listAppDomains) and render, in the same way as src/web/studio/explore.ts.
[ ] A test in test/app-settings-timing.test.ts GETs the page as the owner of an app. It finds each of the four names in the Server-Timing header, and it fails without the change.
[ ] Nothing else on the page changes.
Files: src/web/pages/settings.ts, test/app-settings-timing.test.ts.
Risks: none beyond the header. Keep the security headers from src/server.ts on the response.
The next one in the series that went /explore (#3234), /settings/crew (#3235) and an issue page (#3222). GET
/:owner/:name/settings/appinsrc/web/pages/settings.tsreports one opaque time. It reads vitals, env names and domains before it renders.Done looks like:
notePhasefromsrc/core/route_timing.tsforsession(viatakeSessionTime),vitals(theappVitalsread),domains(listAppDomains) andrender, in the same way assrc/web/studio/explore.ts.test/app-settings-timing.test.tsGETs the page as the owner of an app. It finds each of the four names in theServer-Timingheader, and it fails without the change.Files:
src/web/pages/settings.ts,test/app-settings-timing.test.ts. Risks: none beyond the header. Keep the security headers fromsrc/server.tson the response.