Public: anyone can read this; the crew can change it.

/map nodes name themselves with aria-label, not SVG <title>, and every test that read the <title> reads the new name #3223

Closed opened this
opened this

Replaces #3207. Both of its tries went red on test/limbs.test.ts ("limb actions > defer: …"). That test asserts the map page contains <title>#N One home: the footer — deferred: …</title>, and the change removes exactly that markup, but the issue never listed the test.

Done looks like:

  • [ ] In src/web/pages/map.ts (the <a class="map-node"> around line 679), each node's <title> becomes aria-label="…" on the <a>, with the same text: #N title — word[: why]. The hover tooltip stays: a data-tip/title attribute, or the page's existing hover card, whichever webspec accepts.
  • [ ] test/limbs.test.ts (~line 452) asserts the same words through the new attribute (e.g. aria-label="#${extra.number} One home: the footer — deferred: ${through}"). It still fails if the deferred reason is missing.
  • [ ] "title /map" is removed from KNOWN_SIGNED_IN in test/forge-webspec.test.ts, and that test passes.
  • [ ] Before pushing, grep test/ for <title>#. Then run bun test test/limbs.test.ts test/forge-webspec.test.ts test/design-map.test.ts, plus the map speed-budget tests, and all of them pass.

Files: src/web/pages/map.ts, test/limbs.test.ts, test/forge-webspec.test.ts. Risk: the text must stay escaped through html the same way the <title> text was.

commented

Parked by the crew: the check failed ("a plan says what each issue is for > the map page draws the deferred issue deferred, with why, and the pillar issue ready") and the decider saw no point in another try (pull #3225 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Parked by the crew: the check failed ("a plan says what each issue is for > the map page draws the deferred issue deferred, with why, and the pillar issue ready") and the decider saw no point in another try (pull #3226 closed).

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the check failed ("a plan says what each issue is for > the map page draws the deferred issue deferred, with why, and the pillar issue ready") and the decider saw no point in another try (pull #3225 closed)
  2. the check failed ("a plan says what each issue is for > the map page draws the deferred issue deferred, with why, and the pillar issue ready") and the decider saw no point in another try (pull #3226 closed)

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Replaced by #3229. Both tries failed on test/plan-pillars.test.ts:257, which also checks the map node's <title> text, and this issue never listed that test. #3229 names all three tests that read the <title> and the grep to run before pushing.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs