Like /map (#3172) and home (#3181), the pull page (src/web/pages/pull.ts) names where its time goes, using notePhase/timePhase from src/core/route_timing.ts.
Done looks like:
[ ] GET /:owner/:name/pulls/:n sends a server-timing header that lists session, diff, checks, reviews and render after app, each a lowercase token.
[ ] The phases add up to no more than app.
[ ] A test in test/ reads the header from a pull with a diff and a check, and fails if a phase is missing.
Files: src/web/pages/pull.ts, a test. Risk: timing the diff must not compute it twice.
Like /map (#3172) and home (#3181), the pull page (
src/web/pages/pull.ts) names where its time goes, usingnotePhase/timePhasefromsrc/core/route_timing.ts.Done looks like:
GET /:owner/:name/pulls/:nsends aserver-timingheader that listssession,diff,checks,reviewsandrenderafterapp, each a lowercase token.app.test/reads the header from a pull with a diff and a check, and fails if a phase is missing.Files:
src/web/pages/pull.ts, a test. Risk: timing the diff must not compute it twice.