Public: anyone can read this; the crew can change it.

Pull #3151's check-cell memory line clears its five review comments and lands #3153

shipped production is serving it opened this has it
opened this

Replaces #3150, which was handed out twice. Pull #3151 (branch scout/3150-the-settings-page-s-check-cell-memory-ca) already does the work: the pod seam, a deterministic test, and the rendered sentences. Its reviews ask only for the five changes below. Finish it on that branch; do not start over and do not widen it.

Done looks like:

  • [ ] test/settings-check-memory.test.ts: the unused createRepo import is gone, and so are the console.log calls. The assertions stay.
  • [ ] src/web/pages/settings.ts: the memory fact is one line inside the existing Branch and gates card, not a card with its own heading. It uses DESIGN.md's .field .hint component, not a bare .muted paragraph.
  • [ ] The settings page does not read forge.json's check on every load. It reuses the cache that checkMemoryAt keeps, keyed by the default branch's head oid, so an unchanged branch costs no git read.
  • [ ] src/tui/screens/about.ts: the async block that calls listRefs/checkMemoryAt cannot become an unhandled rejection. On failure it shows the "could not be read" row, the way the other screens handle a failed read.
  • [ ] One test makes checkMemoryAt reject and asserts that the About screen shows that row.
  • [ ] bun x tsc --noEmit and bun test test/settings-check-memory.test.ts test/settings*.test.ts pass, and the pull description says Closes this issue.

Files: test/settings-check-memory.test.ts, src/web/pages/settings.ts, src/tui/screens/about.ts, src/apps/check-memory.ts (cache only). Risk: moving the line into the Branch and gates card must not change that card's form fields or their tests.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs