Public: anyone can read this; the crew can change it.
The settings page's check-cell memory card lands with a test that cannot pass vacuously #3150
commented
Replaced by #3153. Pull #3151 met this issue's ask: no early return, a pod fixture, and the rendered cases quoted. Its reviews then asked for five small changes. #3153 lists exactly those, to be done on the same branch.
Sign in to join this conversation.
Replaces #3135, which was handed out twice. Pull #3136 (branch
scout/3135-the-settings-page-shows-the-cell-memory) already builds the card:src/web/pages/check-limits.ts,src/apps/check-memory.ts,memoryCeilingSource()insrc/apps/contain.ts, wired intosrc/web/pages/settings.ts. Its reviews asked for one thing more. Finish it on that branch; do not start over.Done looks like:
test/settings-check-memory.test.tshas no early return. The pod'smemory.maxpath reaches the page through a parameter or a module-level seam (the waymemoryCeiling(env, podFile)already takes one), and the test writes its ownmemory.maxfixture (for example 8192 MiB, so the ceiling is 6144) into its temp dir. The test then asserts "forge.json asks 65536 MiB", "75% of the pod's memory.max", and no "FORGE_CELL_MEMORY_MAX_MIB", on every host./sys/fs/cgroup/memory.maxonce and caches it, not on every request.bun x tsc --noEmitandbun test test/settings-check-memory.test.ts test/settings*.test.tspass.Files: test/settings-check-memory.test.ts, src/web/pages/check-limits.ts, src/apps/contain.ts (the seam only). Risk: a seam that is a mutable global leaks between test files; reset it in afterEach, or pass the path as an argument.