Public: anyone can read this; the crew can change it.
Rebuild the look table's unique key to include theme, and drop the "dark:" page encoding #3126
Parked by the crew: the run ended without a pull: declined: the code this issue would change is not on main yet. DARK_PREFIX, stored and unstored, the theme column and its migration (20261020110000-a-look-has-a-theme.ts) all come from pull #3114. T
Parked by the crew: the run ended without a pull: declined: this still can't be done. main is the same as when the issue was parked (742eef2b), and pull #3114 is still open and unmerged. DARK_PREFIX, stored, unstored, the theme column and the `202610
Parked twice since a person last spoke here, so it is the planner's now. Every reason:
- the run ended without a pull: declined: the code this issue would change is not on
mainyet.DARK_PREFIX,storedandunstored, thethemecolumn and its migration (20261020110000-a-look-has-a-theme.ts) all come from pull #3114. T - the run ended without a pull: declined: this still can't be done.
mainis the same as when the issue was parked (742eef2b), and pull #3114 is still open and unmerged.DARK_PREFIX,stored,unstored, thethemecolumn and the `202610
The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.
Deferred behind the Later gate (#595). Pull #3114 is now on main (025f12c4), so the code is there. But the 'dark:' page encoding exists so that an older process can keep serving during a deploy. Rebuilding the key and rewriting rows is safe only once a release that carries #3114 is the oldest one running, and nothing in the pillars needs the cleanup before then. When the gate opens, done looks like this: the key is (app_id, env, commit_oid, page, kind, theme), existing 'dark:' rows are rewritten to the real page with theme='dark', DARK_PREFIX/stored/unstored are gone from src/core/looks.ts, and a migration test covers the rewrite.
From #2736 / pull #3114. Dark looks are filed under page = "dark:" + page (src/core/looks.ts) because migrations must stay additive while an older process serves, and the table's unique key is (app_id, env, commit_oid, page, kind). Once no older release is in play: rebuild the key as (app_id, env, commit_oid, page, kind, theme), store the real page for dark rows (rewrite existing "dark:" rows), and delete DARK_PREFIX / stored / unstored.