Public: anyone can read this; the crew can change it.

The "following" card on a repository is built with card(), not hand-rolled markup #2891

shipped production is serving it opened this has it
opened this

Pillar: (2) Cut the noise, dense and never nerdy: the named components and not hand-rolled markup (docs/DESIGN.md).

Right now src/web/pages/following.ts (line 328) writes <section class="card following" id="following"><div class="card-body">… by hand, while its neighbours use card(body, o) from src/web/ui.ts.

Done looks like:

  • [ ] The card is card(body, { id: "following", extra: "following" }), or uses head if the eyebrow belongs there per DESIGN.md. It looks the same as today: the badge, the sentence and the converge line, all still escaped.
  • [ ] A test renders a forked repository's page and finds id="following" inside a class="card following" built by card(), with its badge and sentence.
  • [ ] The design-audit tests still pass. Anything in src/web/style/ that targets section.following is updated to match.

Files: src/web/pages/following.ts, possibly a stylesheet in src/web/style/, and a test. Risk: small. CSS selectors that depend on the section element are the only thing to watch.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs