Public: anyone can read this; the crew can change it.

The terminal's pull screen shows each named team's review verdict, and an approval followed by a comment still counts #2857

shipped production is serving it opened this has it
opened this

The follow-up to pull #2839 (#2681), carrying what sentinel's third review left open. It waits until #2681 lands, because it uses teamVerdicts from src/core/issue_teams.ts.

Done looks like:

  • [ ] The terminal pull screen (src/tui/screens/pull.ts, next to the verdict list) shows one muted line per team the issue names, for example Design: approved by quill or Security: awaiting a reviewer. It shows nothing when the issue names no team.
  • [ ] teamVerdicts takes each member's newest verdict that is not a plain comment, so approve-then-comment still reads as approved and no new review run is queued.
  • [ ] sendToTeams (src/crew/review.ts) keeps a set of the reviewers queued in one pass, so a reviewer on two teams is asked once.
  • [ ] Tests: a headless-terminal test that fails without the lines, an approve-then-comment test, and a test that one reviewer on two teams gets exactly one run.
  • [ ] The README sentence about where team verdicts show names the terminal.

Files: src/tui/screens/pull.ts, src/core/issue_teams.ts, src/crew/review.ts, README, test/.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs