Public: anyone can read this; the crew can change it.

A changes-requested pull whose follow-up run ended without a push gets one more run with the reviewer's words, then goes to a person #2855

shipped production is serving it opened this has it
opened this

Split from #2847. Today followUp in src/crew/requested.ts refuses with "a run since the verdict ended without a push" forever, so the pull sits until the steward re-assigns it by hand.

Done looks like:

  • [ ] If exactly one non-review run started after the verdict and ended without a push, the requested pass queues one more feedback run for the builder. That run's prompt carries the reviewer's latest verdict body and the previous run's final answer, so the builder sees why its last try did not land.
  • [ ] After that second run also ends without a push, the pull is handed to a person (the existing handover) and the pass stops trying. It is at most two follow-ups per verdict.
  • [ ] A pass with a run in flight queues nothing.
  • [ ] Tests in test/requested.test.ts: a pull with one pushless run since the verdict gets exactly one new run within one tick. A second tick does not start another. After two pushless runs it is handed over.

Files: src/crew/requested.ts, the feedback prompt builder it uses, test/requested.test.ts.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs