Public: anyone can read this; the crew can change it.

/flow answers 301 to /boards and the top bar has no Flow button #2808

Closed opened this
opened this

The rest of #2767, once no test reads /flow.

Done:

  • [ ] GET /flow answers 301 to /boards
  • [ ] the top bar keeps search, New and the user menu, and has no Flow button
  • [ ] the change only removes markup and CSS and adds no colour or size, so test/design-lint.test.ts passes against docs/design/baseline.json without touching the baseline
  • [ ] test: /flow is a 301 to /boards, and the home's top bar has no link to /flow

Merge main first: the earlier pulls conflicted in README.md and test/system-telemetry.test.ts. Run test/design-lint.test.ts, test/crew-held.test.ts and test/merge-queue.test.ts before pushing.

commented

Parked by the crew: the check failed ("the repository > carries no hollow work beyond what is allowed, and allows nothing that is reached") and the decider saw no point in another try (pull #2821 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Parked by the crew: the check failed ("a reader's fork pull runs nothing until a writer approves its head > a reader's fork pull queues no check") and the decider saw no point in another try (pull #2827 closed).

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the check failed ("the repository > carries no hollow work beyond what is allowed, and allows nothing that is reached") and the decider saw no point in another try (pull #2821 closed)
  2. the check failed ("a reader's fork pull runs nothing until a writer approves its head > a reader's fork pull queues no check") and the decider saw no point in another try (pull #2827 closed)

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Split. The first pull failed test/hollow.test.ts because the redirect left the /flow page code unreached. #2831 only removes the links to /flow (top bar, palette, /system, /telemetry). #2832 then redirects /flow and deletes the dead page code instead of allow-listing it, and waits for #2831.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs