Public: anyone can read this; the crew can change it.

/asks renders what needs you as its own page, and every test reads asks from /asks instead of the home #2799

shipped production is serving it opened this has it
opened this

Why: #2764 (the owner's home shows no asks) failed twice because tests read asks out of the home's <section id="needs-you">. Move them first, and leave the home alone in this pull.

Done:

  • [ ] GET /asks renders the needs-you section (the same markup and the same live script) as a full page. Today it redirects to /#needs-you
  • [ ] these tests read asks from /asks instead of /: test/holds.test.ts, test/asks.test.ts, test/asks-rank.test.ts, test/asks-expiry.test.ts, test/asks-mute.test.ts, test/review-wait.test.ts, test/web-apps.test.ts, and the / expectation in test/planner-declined.test.ts. Assertions stay the same and only the URL changes. The pull lists each file
  • [ ] the home is unchanged in this pull

Files: src/http/server.ts (the /asks route), src/web/studio/asks.ts or a new src/web/asks-page.ts, and the tests above. Run those suites before pushing.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs