Public: anyone can read this; the crew can change it.

test/web.test.ts's refused cross-origin log test holds its own log floor and passes in the full suite #2798

shipped production is serving it opened this has it
opened this

Why: pull #2782 for the owner's no-asks home failed on this test. An earlier test file left the log floor above warn, so the refusal was never logged.

Done:

  • [ ] the describe in test/web.test.ts that holds "a mismatched origin is refused and logged with both origins" sets the floor to warn for its own scope (quietLogs("warn") from test/helpers/globals.ts) and puts it back afterwards
  • [ ] the pull names which file leaves the floor raised, if it can be found, and makes that file restore it
  • [ ] no product code changes

Files: test/web.test.ts, maybe one test file that leaks the floor. Run test/web.test.ts before pushing.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs