Public: anyone can read this; the crew can change it.

The owner's home shows no asks; the planner's decline moves to /board and the asks page (test updated on purpose) #2764

Closed opened this
opened this

Replaces #2738. Both pulls were stopped by test/planner-declined.test.ts > "a decline is an ask for the owner…". It expects / to contain "The planner declined the direction", which is exactly what the owner asked to remove ("i really really hate the things for me on the home screen").

Done:

  • [ ] the owner's home renders no for-you, asks or things-for-me list or count
  • [ ] asks stay on their own page, linked from the top bar without a count badge
  • [ ] in test/planner-declined.test.ts, the expectation on / becomes the asks page; /board's expectations stay. Say in the pull which test changed and why
  • [ ] test: the owner's home with six open asks contains none of them

Run test/planner-declined.test.ts and the home tests before pushing.

commented

Parked by the crew: the check failed ("a refused cross-origin mutation says why in the log > a mismatched origin is refused and logged with both origins") and the decider saw no point in another try (pull #2782 closed). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Parked by the crew: the check failed ("a hold is set, shown and lifted > a hold asks nothing of the person who set it; another person who writes is still asked") and the decider saw no point in another try (pull #2784 closed).

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the check failed ("a refused cross-origin mutation says why in the log > a mismatched origin is refused and logged with both origins") and the decider saw no point in another try (pull #2782 closed)
  2. the check failed ("a hold is set, shown and lifted > a hold asks nothing of the person who set it; another person who writes is still asked") and the decider saw no point in another try (pull #2784 closed)

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Split. Both pulls failed for the same reason: tests read asks out of the home's needs-you section (test/holds.test.ts and six other suites), and the web.test.ts log check depends on a log floor that leaks between files. #2798 fixes that floor. #2799 makes /asks a real page and moves every test that reads asks onto it. #2800 then removes asks from the home, and it waits for both.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs