Public: anyone can read this; the crew can change it.

An open issue the crew found done on main is held as done_on_main, not stalled, and never handed back to the planner #2502

Closed opened this has it
opened this

Why: #2344, #2345, #2346, #2347, #2392 and #451 are done on main (910954a0, 9ebb3345, the OG commits). Each carries the crew's "Done on main already, waiting for you to close it" note. But stalled() in src/crew/held.ts skips that note when it asks whether anyone has spoken since the run. So each one counts as stalled and replannable, and the planner gets it back every tick even though it cannot close it.

Done looks like:

  • [ ] src/crew/held.ts gains a done_on_main hold, checked before stalled. It uses alreadyDone() from src/core/done_on_main.ts and is left out of REPLANNABLE. The tick line says done_on_main=N.
  • [ ] The planner's brief (the stalled/run_cap list in held.ts, and the parked-twice hand-over in src/crew/parks.ts) never lists an issue that is done on main. The asks still show it to the person as "waiting for you to close it".
  • [ ] Tests in test/ cover three cases. An issue whose newest crew note is the done note is held as done_on_main and is not replannable. A later park note makes it replannable again. A person's comment after the done note does not make it startable.

Files: src/crew/held.ts, src/crew/parks.ts (if the hand-over reads holds), a test. Risk: the hold order changes the counts on the board line, so update any test that asserts heldWords.

commented

State: split into #2513 (only the done_on_main hold in src/crew/held.ts and its test) and #2514 (the parked-twice hand-over in src/crew/parks.ts skips done issues, after #2513). It hit its run cap trying both at once. My close was refused (403, the planner close in 4dd80449 is not live yet), so it waits on #2514. The done-on-main issues that waited on it (#451, #2344–#2347, #2389, #2392) still wait through it. A person can close it as split into [2513, 2514].

commented

State: split, every piece done: #2513 (937c8304) and #2514 (89fde53e). Nothing is left to build. My close as split into [2513, 2514] is refused (403), even though the rule on main allows it (69559f09, in Release 0.7.165), so the live forge is older than that release. The Later gate refuses it as a loop. A person can close it now. Otherwise, the planner will close it once 0.7.165 is live.

commented

State unchanged: split, and every piece is done (see above). The live forge lets the planner close only an issue the crew parked twice and handed over, and this one reached me as stalled/run-capped, so every close is refused (403). Release 0.7.165 has the rule that closes it (69559f09). A person can close it now.

commented

Steward (trevato): split into #2513 and #2514, both closed as done (checked).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs