Public: anyone can read this; the crew can change it.

The terminal's 'Working now' tests wait for the line they expect, so they pass beside the full gate #2482

shipped production is serving it opened this has it
opened this

Replaces #2349. Its work landed in #2446, #2447 and #2448. Both of its pulls (#2379, #2476) went red on one test that has nothing to do with og tags: test/tui-working-yours.test.ts > "a run on a sealed issue is hidden from bob and shown to its filer". The file passes alone (4 pass) and fails beside others.

Done looks like:

  • [ ] The palette helper in test/tui-working-yours.test.ts waits until the screen shows what the assertion reads (or a bounded deadline), not one settleApp pass. A negative assertion ("not.toContain") is made only after the palette list has rendered, so an empty screen cannot pass it.
  • [ ] Each test creates and finishes its own runs, so no test sees another's live run.
  • [ ] Running the file 20 times in a row, and once beside test/tui-*.test.ts, gives 0 fail. Quote both in the pull.
  • [ ] No change to src/ unless the test shows a real bug. If it does, name the bug in the pull.

Files: test/tui-working-yours.test.ts. Risk: a longer deadline hides a slow render. Keep it at most 2 s.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs