Public: anyone can read this; the crew can change it.

Passkey signup and OAuth-made accounts go through signupAllowed, not signinAllowed #2365

shipped production is serving it opened this has it
opened this

Part of #2322. src/web/pages/signup-passkey.ts borrows signinAllowed today.

Done looks like:

  • [ ] Passkey signup, and any OAuth callback that creates an account, call signupAllowed(ctx) before they make the account. A callback that creates nothing (for example error=access_denied) is not counted.
  • [ ] test/signup-passkey.test.ts and the OAuth code-flow suite ("a callback carrying error=access_denied burns the state and creates nothing"; find it with grep -l 'OAuth code flow' test/*.ts) stay green. A suite raises signup.per_source in its setup when it needs more than 5 signups, and changes no assertion.
  • [ ] Test: a passkey signup past the limit is refused with the wait.
Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs